Open
Conversation
for more information, see https://pre-commit.ci
Merge branch 'dyoc_docs_update' of github.com:Parcels-code/virtualship into dyoc_docs_update
Collaborator
Author
|
Should be fine now. You want to have a look @j-atkins? |
Collaborator
|
Will have a look now! I also added an update which had been on my to do list! |
j-atkins
reviewed
Feb 12, 2026
Collaborator
j-atkins
left a comment
j-atkins
left a comment
There was a problem hiding this comment.
Looks good! Just a couple of tiny details
| "source": [ | ||
| "## Code of conduct\n", | ||
| "_As used during the Dynamical Oceanography 2025/26 course at Utrecht University_" | ||
| "_As used during the Dynamical Oceanography 2026/27 course at Utrecht University_" |
Collaborator
There was a problem hiding this comment.
Isn't this one year too far ahead? I already updated this in #271
Comment on lines
+100
to
+104
| "<!-- TODO: this note can be removed when CTD and CTD_BGC are combined to one instrument -->\n", | ||
| "<div class=\"alert alert-block alert-info\"> \n", | ||
| "**Note**: If you are deploying CTDs in both standard and biogeochemical configurations (`CTD` and `CTD_BGC`) in your [VirtualShip expeditions](./Sail_the_ship.ipynb), you only need to factor in the 50 minutes **once** per waypoint, as both can be deployed on the same cast.\n", | ||
| "</div>\n", | ||
| "\n", |
Collaborator
There was a problem hiding this comment.
This is what I added - are you happy with this @ammedd ?
Collaborator
Author
|
Hi @j-atkins, could you please merge this if you're happy with the changes? I'm out of office until next week Thursday and I think it's good to get it merged before then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for now because I need to look at the read-the-docs built still
Updates documents to current VirtualShip capabilities